Browse Source

noop: add some FIXMEs

libpanel_detach
Alexandros Theodotou 2 months ago
parent
commit
70f016900d
Signed by: alex
GPG Key ID: 022EAE42313D70F3
  1. 6
      src/audio/engine_jack.c
  2. 2
      src/audio/engine_pulse.c

6
src/audio/engine_jack.c

@ -1,7 +1,5 @@ @@ -1,7 +1,5 @@
// SPDX-FileCopyrightText: © 2018-2022 Alexandros Theodotou <alex@zrythm.org>
// SPDX-License-Identifier: LicenseRef-ZrythmLicense
/*
* Copyright (C) 2018-2022 Alexandros Theodotou <alex at zrythm dot org>
*/
#include "zrythm-config.h"
@ -711,6 +709,8 @@ engine_jack_reconnect_monitor (AudioEngine * self, bool left) @@ -711,6 +709,8 @@ engine_jack_reconnect_monitor (AudioEngine * self, bool left)
JackPortIsPhysical | JackPortIsInput);
if (ports == NULL || ports[0] == NULL || ports[1] == NULL)
{
/* FIXME handle gracefully - just don't connect to
* anything and show an error in the UI */
g_critical ("no physical playback ports found");
return -1;
}

2
src/audio/engine_pulse.c

@ -137,6 +137,7 @@ engine_pulse_stream_state_callback ( @@ -137,6 +137,7 @@ engine_pulse_stream_state_callback (
g_message ("Pulse stream ready");
break;
case PA_STREAM_FAILED:
/* FIXME handle gracefully */
g_critical (
"Error in pulse stream: %s",
pa_strerror (pa_context_errno (pulse)));
@ -171,6 +172,7 @@ engine_pulse_context_state_callback ( @@ -171,6 +172,7 @@ engine_pulse_context_state_callback (
g_message ("Pulse context ready");
break;
case PA_CONTEXT_FAILED:
/* FIXME handle gracefully */
g_critical (
"Error in pulse context: %s",
pa_strerror (pa_context_errno (pulse)));

Loading…
Cancel
Save